-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish it & merge into main repository #1
Conversation
|
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: baiyutang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kitex-contrib org. You can then trigger verification by writing
|
/approve |
all done! |
@baiyutang LGTM, but seems CI failed |
|
Nacos 中的兼容性问题需要说明一下。这个仓库用的是 1.x 版本的 sdk, 和 2.x 版本的 nacos server 可能有兼容性问题,需要测试说明兼容情况,麻烦弄一下。 |
单侧可以把 register 和 resolve 结合起来。看看 resolve 之后获取的 instance 是否和 resgiter 之前的 instance 属性相同。 |
这个是有的。可以完善下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.