Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish it & merge into main repository #1

Merged
merged 21 commits into from
Jan 27, 2022
Merged

Finish it & merge into main repository #1

merged 21 commits into from
Jan 27, 2022

Conversation

baiyutang
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2021

CLA assistant check
All committers have signed the CLA.

@bytedance-oss-robot bytedance-oss-robot bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 16, 2021
@baiyutang
Copy link
Collaborator Author

baiyutang commented Dec 16, 2021

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kitex-contrib org. You can then trigger verification by writing /verify-owners in a comment.

  • baiyutang

    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@YangruiEmma @simon0-o

@baiyutang
Copy link
Collaborator Author

/approve

@bytedance-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: baiyutang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bytedance-oss-robot
Copy link

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kitex-contrib org. You can then trigger verification by writing /verify-owners in a comment.

  • baiyutang
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@baiyutang
Copy link
Collaborator Author

/approve

registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
@baiyutang
Copy link
Collaborator Author

all done!

go.mod Outdated Show resolved Hide resolved
registry/registry.go Show resolved Hide resolved
README.md Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
resolver/resolver.go Show resolved Hide resolved
test/registry_test.go Outdated Show resolved Hide resolved
@joway
Copy link

joway commented Dec 27, 2021

@baiyutang LGTM, but seems CI failed

@baiyutang
Copy link
Collaborator Author

@baiyutang LGTM, but seems CI failed
I will check it this tonight.

registry/registry.go Show resolved Hide resolved
registry/registry.go Show resolved Hide resolved
registry/registry.go Show resolved Hide resolved
@horizonzy
Copy link

Nacos 中的兼容性问题需要说明一下。这个仓库用的是 1.x 版本的 sdk, 和 2.x 版本的 nacos server 可能有兼容性问题,需要测试说明兼容情况,麻烦弄一下。

@horizonzy
Copy link

单侧可以把 register 和 resolve 结合起来。看看 resolve 之后获取的 instance 是否和 resgiter 之前的 instance 属性相同。

@baiyutang
Copy link
Collaborator Author

单侧可以把 register 和 resolve 结合起来。看看 resolve 之后获取的 instance 是否和 resgiter 之前的 instance 属性相同。

这个是有的。可以完善下

go.mod Show resolved Hide resolved
@baiyutang baiyutang requested a review from joway January 25, 2022 11:28
Copy link

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

resolver/resolver.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
example/client/main.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
@GuangmingLuo GuangmingLuo merged commit 9b8855f into kitex-contrib:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants