Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add script to test sub project and add more unit test for nacos v2 #29

Merged
merged 1 commit into from
Jan 13, 2024
Merged

chore: Add script to test sub project and add more unit test for nacos v2 #29

merged 1 commit into from
Jan 13, 2024

Conversation

Skyenought
Copy link
Contributor

@Skyenought Skyenought commented Jan 12, 2024 •
edited

desc

  • Add script to test sub project
  • Add more unit test for nacos v2

li-jin-gou
li-jin-gou approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加 PR 描述/更新 title

li-jin-gou
li-jin-gou requested changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

添加 PR 描述/更新 title

@Skyenought Skyenought changed the title Add script to test sub project and add more unit test for nacos v2 chore: Add script to test sub project and add more unit test for nacos v2 Jan 13, 2024
@bytedance-oss-robot bytedance-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: li-jin-gou, Skyenought
To complete the pull request process, please assign joway after the PR has been reviewed.
You can assign the PR to them by writing /assign @joway in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@li-jin-gou li-jin-gou merged commit 7e572af into kitex-contrib:main Jan 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jin-gou li-jin-gou li-jin-gou approved these changes

@baiyutang baiyutang Awaiting requested review from baiyutang

@joway joway Awaiting requested review from joway

Assignees

@felix021 felix021

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skyenought @li-jin-gou @felix021