-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add service-comb registry and resolver implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: resolver init
feat: add env and UT
refactor: change Deregister and UT
fix: fix heart beat ticker
# Conflicts: # registry/registry.go # registry/registry_test.go
Feat sc resolve
add ci fmt code add example
Feat sc resolve
参考其它项目加一下 owners 文件 |
/verify-owners |
Feat sc resolve
不要自己 resolve 让CR的人来 @bodhisatan |
fix: exec gofumpt
GuangmingLuo
reviewed
Aug 1, 2022
GuangmingLuo
reviewed
Aug 1, 2022
chore(example): WithRegistryInfo replace by WithServerBasicInfo
chore: fmt README.md
li-jin-gou
approved these changes
Aug 1, 2022
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bodhisatan, li-jin-gou The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.