Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zookeeper registry complete #1

Merged
merged 45 commits into from
Nov 15, 2021
Merged

Zookeeper registry complete #1

merged 45 commits into from
Nov 15, 2021

Conversation

horizonzy
Copy link
Collaborator

No description provided.

@YangruiEmma YangruiEmma self-requested a review October 13, 2021 03:25
lsjbd
lsjbd reviewed Oct 13, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
discovery_test.go Outdated Show resolved Hide resolved
server_java_test.go Show resolved Hide resolved
simon0-o
simon0-o reviewed Oct 27, 2021
View reviewed changes
discovery_test.go Outdated Show resolved Hide resolved
YangruiEmma
YangruiEmma reviewed Nov 8, 2021
View reviewed changes
go.mod Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
registry/registry.go Outdated Show resolved Hide resolved
YangruiEmma
YangruiEmma reviewed Nov 10, 2021
View reviewed changes
utils/const.go Outdated Show resolved Hide resolved
YangruiEmma
YangruiEmma reviewed Nov 10, 2021
View reviewed changes
resolver/zookeeper.go Outdated Show resolved Hide resolved
GuangmingLuo
GuangmingLuo reviewed Nov 11, 2021
View reviewed changes
Makefile Show resolved Hide resolved
GuangmingLuo
GuangmingLuo reviewed Nov 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@horizonzy
comment format.
b8959a6
@horizonzy
con -> conn
5d4a473
@horizonzy
add more info.
e4c6541 
# Conflicts:
#	Makefile
@horizonzy
Merge branch 'zookeeper-registry' of https://github.com/horizonzy/reg…
486d04d 
…istry-zookeeper into zookeeper-registry

# Conflicts:
#	.github/workflows/pr-check.yml
#	.github/workflows/push-check.yml
#	Makefile
@horizonzy horizonzy mentioned this pull request Nov 12, 2021
Closed
3 tasks
@Summer-Field
Copy link

/lgtm

@bytedance-oss-robot bytedance-oss-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@Summer-Field
Copy link

/approve

1 similar comment
@YangruiEmma
Copy link
Contributor

/approve

@Jeffwan Jeffwan added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@GuangmingLuo
Copy link
Member

Thanks a lot. And please add this sentence in the beginning of Readme:
"This is a community driven project."

@bytedance-oss-robot bytedance-oss-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@horizonzy
Copy link
Collaborator Author

Thanks a lot. And please add this sentence in the beginning of Readme: "This is a community driven project."

fine.

@Summer-Field
Copy link

/lgtm

@bytedance-oss-robot bytedance-oss-robot bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Nov 12, 2021
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@horizonzy
Copy link
Collaborator Author

@YangruiEmma @simon0-o Hi, CLA should be sign.

@YangruiEmma
Copy link
Contributor

/verify-owners

@bytedance-oss-robot bytedance-oss-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@bytedance-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@bytedance-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GuangmingLuo, horizonzy, simon0-o, Summer-Field, YangruiEmma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bytedance-oss-robot bytedance-oss-robot bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 15, 2021
@YangruiEmma YangruiEmma merged commit e43593f into kitex-contrib:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsjbd lsjbd lsjbd left review comments

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@GuangmingLuo GuangmingLuo GuangmingLuo approved these changes

@simon0-o simon0-o simon0-o approved these changes

Assignees

@Summer-Field Summer-Field

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@horizonzy @Summer-Field @YangruiEmma @GuangmingLuo @CLAassistant @simon0-o @lsjbd @Jeffwan