-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No page image loading #908
Comments
An other way to reproduce this, is to use our docker images:
|
The problem seems to be the following:
So we have a mismatch of default configuration requiring the use of the internal proxy in the PageView plugin, but not enabling it in the first place. I suggest reverting the change to What do you think, @csidirop and @beatrycze-volk? |
If after that proxy for 3D models works, than I'm fine with your solution :) |
We would have to rework this a little bit: Currently there are two different configuration options effectively meaning the same thing: Instead of being a boolean switch,
But I am not sure if I understand the meaning of |
Yes I think we need a consistent way of doing it. I think the approach to leave it as it was by default and activate it as needed is good. But to be honest I haven't understood exactly what the internal image proxy does and what it's for. |
I think we got here to some deeper misunderstanding.
Also in places in which we are using proxy we are querying for We need to definitely consolidate those two settings into one. For now probably reversing of adding it to the global typo setup should solve the problem. |
How should we proceed here? |
I am currently working on simplifying the 3D support and in turn reverting the changes regarding the internal proxy. It will take a few more weeks due to vacations, but this should fix this issue. |
Okay thanks. |
Temporally workaround to fix kitodo#908 Signed-off-by: Christos Sidiropoulos <csidirop@runbox.com>
It seams like with the version 4.x from 21 Jul 23 (38b64ca) the image is shown again. Is this fixed or a workaround / temporally solution or even just a coincidence? |
Close the issue because it is probably fixed, even if it is not clear why. |
Description
Using latest presentation and DFG-Viewer code lead to GET error
404 eID not registered
(see error message below), so that the image cannot be loaded.I tracked this bug down to following commit: 2578e7a from 27 Oct. 22. This commit contained changes in PageViewPlugin.php and setup.typoscript which have changed the behavior of the get request.
For the moment not using the internal proxy fixes the issue.
Reproduction
Steps to reproduce the behaviour:
Expected Behavior
The page image is shown.
Screenshots and Examples
The full error message:
Environment
Additional Context
The text was updated successfully, but these errors were encountered: