Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Restore usage of DataHandler #1212

Merged
merged 7 commits into from
May 28, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

@beatrycze-volk beatrycze-volk commented May 24, 2024

Records are inserted and translated correctly. Sorting is automatically assigned on insertion.

dh4png

One the edit only original records has index_name field.

dh2png

On the edit of the translation record only label, value and wrapper can be changed.

dh3png

@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label May 24, 2024
@sebastian-meyer sebastian-meyer changed the title [FEATURE] Restore usage of DataHandler [BUGFIX] Restore usage of DataHandler May 24, 2024
@sebastian-meyer sebastian-meyer self-requested a review May 24, 2024 08:52
@beatrycze-volk beatrycze-volk marked this pull request as draft May 24, 2024 09:07
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix for a Codacy issue.

Classes/Controller/Backend/NewTenantController.php Outdated Show resolved Hide resolved
@sebastian-meyer sebastian-meyer removed this from the Kitodo.Presentation 5.1.0 milestone May 28, 2024
@sebastian-meyer sebastian-meyer merged commit 3e7fda6 into kitodo:master May 28, 2024
6 checks passed
sebastian-meyer added a commit that referenced this pull request May 28, 2024
Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
@beatrycze-volk beatrycze-volk deleted the datahandler branch May 28, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants