Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Add $field to the facetset otherwise the name of the field does not exist #1271

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

chrizzor
Copy link
Collaborator

No description provided.

@sebastian-meyer sebastian-meyer self-requested a review July 11, 2024 07:22
@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label Jul 11, 2024
@sebastian-meyer
Copy link
Member

I don't see the problem here. The field name is provided as key inside the array, so setting it as array-key as well would be duplicated information.
Just for my understanding: Do you get any errors, because the array-key is numerical?

@sebastian-meyer sebastian-meyer changed the title Add $field to the facetset otherwise the name of the field does not exist [BUGFIX] Add $field to the facetset otherwise the name of the field does not exist Jul 11, 2024
@chrizzor
Copy link
Collaborator Author

In my case, the facets no longer worked and the translations also looked strange. As a query for the facets, the name of the field is written in front of the value (fieldname_faceting:value). Instead of fieldname_faceting, the corresponding number of the array is then used. This happens in the foreach loop in the SearchController in line 492. The variable $field is then only the number of the array.

@sebastian-meyer
Copy link
Member

OK, now I see the problem. Thanks for the clarification!

@sebastian-meyer sebastian-meyer merged commit 7e11f6a into kitodo:master Jul 11, 2024
7 checks passed
sebastian-meyer added a commit that referenced this pull request Jul 16, 2024
…oes not exist (#1271)

Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants