Update Solarium to 5.1.6 #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-meyer
added
the
🛠 maintenance
sebastian-meyer
requested changes
Dec 8, 2020
Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
sebastian-meyer
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Sorry, I confused the constructor (which actually uses Solarium to establish the Solr connection) and getSolrUrl() (which is used to create new cores without using Solarium). Some of my review comments were garbage... :o/
I've added a few changes and now it works for me. Does it for you as well?
beatrycze-volk
commented
Dec 9, 2020
|
Yes, it looks ok. |
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highest possible now update of Solarium. Necessary change (https://solarium.readthedocs.io/en/stable/getting-started/):
Since version 5.2 needed is EventDispatcher which in TYPO3 is first available in ver. 10 (https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Hooks/EventDispatcher/Index.html).