-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Integrate ORCID API #829
[FEATURE] Integrate ORCID API #829
Conversation
d54680b
to
f6bedae
Compare
I have discovered error with different formats of given URLs:
|
The first link is not a valid ORCID identifier (but a deep link to a person's personal account page) and we should not support it. Otherwise we would need to support any kind of ORCID link. Only ORCID URIs of the form If someone enters an invalid ORCID link, it should get rejected by the repo's ingest form and not even be added to the XML metadata. |
In current test case, half of the links are inserted as |
25c2746
to
038b398
Compare
For some reason LoggerAwareInterface doesn't work
038b398
to
81a75b0
Compare
Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
cff4b79
to
622ff9e
Compare
The author data like address, email and names can be read from the API if ORCID identifier is included in MODS.
Depends on #828