Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Integrate ORCID API #829

Merged
merged 12 commits into from
Jan 27, 2023

Conversation

beatrycze-volk
Copy link
Collaborator

The author data like address, email and names can be read from the API if ORCID identifier is included in MODS.

Depends on #828

@beatrycze-volk beatrycze-volk force-pushed the integrate-orcid-api branch 2 times, most recently from d54680b to f6bedae Compare July 14, 2022 08:35
@beatrycze-volk beatrycze-volk marked this pull request as draft July 14, 2022 11:00
@beatrycze-volk
Copy link
Collaborator Author

I have discovered error with different formats of given URLs:

@beatrycze-volk beatrycze-volk marked this pull request as ready for review July 14, 2022 11:19
@sebastian-meyer
Copy link
Member

The first link is not a valid ORCID identifier (but a deep link to a person's personal account page) and we should not support it. Otherwise we would need to support any kind of ORCID link.

Only ORCID URIs of the form https://orcid.org/XXXX-XXXX-XXXX-XXXXare persistent identifiers and should be supported.

If someone enters an invalid ORCID link, it should get rejected by the repo's ingest form and not even be added to the XML metadata.

@sebastian-meyer sebastian-meyer self-requested a review July 14, 2022 13:36
@sebastian-meyer sebastian-meyer added the ⚙ feature A new feature or enhancement. label Jul 14, 2022
@beatrycze-volk
Copy link
Collaborator Author

In current test case, half of the links are inserted as https://orcid.org/XXXX-XXXX-XXXX-XXXX and other half as https://orcid.org/my-orcid?orcid=XXXX-XXXX-XXXX-XXXX. I will remove part which handles second type.

@sebastian-meyer sebastian-meyer changed the title Integrate ORCID API [FEATURE] Integrate ORCID API Aug 4, 2022
Classes/Api/Orcid/Client.php Outdated Show resolved Hide resolved
Classes/Api/Orcid/Client.php Show resolved Hide resolved
Classes/Format/Mods.php Outdated Show resolved Hide resolved
beatrycze-volk and others added 2 commits January 26, 2023 17:38
Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>
@sebastian-meyer sebastian-meyer merged commit 72277d3 into kitodo:master Jan 27, 2023
@beatrycze-volk beatrycze-volk deleted the integrate-orcid-api branch January 27, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ feature A new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants