-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] TYPO3 v11 compatibility #885
Conversation
Could you please bring this pull request up to date with master? Thank you! |
Could you please adjust the testing workflow in order to ensure testing against TYPO3 v10 and v11 instead of v9 and v10? Currently tests fail, because they are still run against v9. |
I think we need to update Constraints for tests and in composer.json for TYPO3 v10 and v11 should be (see also: https://get.typo3.org/):
Also please check if we can use the newest version of spatie/phpunit-watcher since we should be able to run PHPUnit 9.x now, are we? After updating composer.json please also update composer.lock file accordingly (by running |
There are a lot of mentions of TYPO3 v9 left in the documentation and code. All of them need to be updated according to the new supported versions. Also, some of them point to work-arounds for backwards compatibility which are no longer needed when dropping support for v9. Please check and remove those work-arounds. |
I did a few tests (on TYPO3 v10 with DFG-Viewer) and while most of the parts I tested worked fine I found following error: Using the search or collection plugin leads to For me this results in some erroneous output:
|
in DocumentTypeFunctionProvider because in this case the construct method doesn't work.
@csidirop @sebastian-meyer : Do you both get the error with the wrong number of hits? |
First of all, could you please bring your branch up to date with kitodo:master as @sebastian-meyer requested one month ago. You are at 31dbff3 and 38 commits behind, some of which fixed bugs. Now, I get the same results regardless weather I'm merging kitodo:master into your branch or not, its still the same error from above. But it may also have something to do with my dev environment. I'll try that asap. But for the moment what I'm doing is checking out your branch in my Docker env after everything is set up (here may be the difference?). Plus I'm using DFG-Viewer which may have some influence. I'll test that too asap. |
So I updated my docker setup to initially setup dlf with your branch, but as soon as I want to add Kitodo Elements to a subpage I get this error:
This issue can be resolved by merging kitodo:master. But after that I'm stuck at some config issue I have no time to resolve now. But I can show you my workflow in case you want to follow this:
I can't rule out, that the error only occurs in my environment. Hopefully sebastian can test it and see if he has the same errors. |
|
I added the missing labels for the database fields. A faulty search and replace caused "Label" to get kicked out. |
I think the escaped single quotes cause problems in this case. With double quotes, it works for me. |
I don't know why (because some lines below it works perfectly with single quotes), but now it works for me as well! |
And |
I have adjusted the TCA accordingly and added information in development.md for v11 and v12. |
Unfortunately the missing search results are still an issue in my tests. Can you reproduce this? |
I had to resolve a lot of merge conflicts, so maybe there are some issues now. Please extensively test the master branch and compare it to what your intended changes for TYPO3v11 compatibility should have been! There is still some work to do, but for now this is finally merged! |
CI tests now fail. Is this related to this PR?
|
Yes, it most likely is. There probably are more issues than just that... |
OK, that was my fault. I accidently duplicated a method while resolving merge conflicts. This is fixed now. But tests still don't run through. @chrizzor Could you please have a look into this? |
Tests under TYPO3 v10 with our DFG-Viewer:
Tests under TYPO3 v11:
|
This PR ensures that the DLF Extension is also compatible with version 11 of Typo3.
The biggest adjustment was the reorganization of the pagination, since the widgets were removed from Typo3. This required an own "Pagniator" for the Solr, as well as for the display of the "PageGrid"