-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListView: add called collection #920
ListView: add called collection #920
Conversation
idea from @michaelkubina see: kitodo#918
Was not sure which branch to take master or 4.x. |
I think all PRs going to master, and master is merged at regular intervals into 4.x |
Please have a look at Resources/Private/Templates/Collection/List.html. This template already contains your proposed additions and is meant to be used with the I am OK with unifying the templates and using only one template for all cases, but then we need to remove the duplicate template and make sure the unified template is always used. |
Yes, that's true until development of a new major version begins. Currently I am working on the 4.1 release, so all pull requests should still target the |
How should we proceed with this pull request, @BFallert? |
But when i clicked on a collection on a page that contains a collection list (plugin: Collection), a normal ListView is called.
Small adjustments would probably still have to be made in the existing template. On the other hand, if I'm the only one with this problem, we can close the PR. |
|
idea from @michaelkubina
see: #918
When a collection is called in a collection list (Kitodo:Collection), a ListView is called. In this ListView it is desirable to be able to output the name of the selected collection (Headline) and its associated data (Thumbnail and Description).
With these adjustments this is possible without further configuration.