Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListView: add called collection #920

Closed

Conversation

BFallert
Copy link
Collaborator

@BFallert BFallert commented Mar 1, 2023

idea from @michaelkubina
see: #918

When a collection is called in a collection list (Kitodo:Collection), a ListView is called. In this ListView it is desirable to be able to output the name of the selected collection (Headline) and its associated data (Thumbnail and Description).

With these adjustments this is possible without further configuration.

@BFallert
Copy link
Collaborator Author

BFallert commented Mar 1, 2023

Was not sure which branch to take master or 4.x.

@BFallert BFallert changed the base branch from master to 4.x March 1, 2023 20:43
@csidirop
Copy link
Contributor

csidirop commented Mar 2, 2023

I think all PRs going to master, and master is merged at regular intervals into 4.x

@sebastian-meyer
Copy link
Member

Please have a look at Resources/Private/Templates/Collection/List.html. This template already contains your proposed additions and is meant to be used with the Collection controller.

I am OK with unifying the templates and using only one template for all cases, but then we need to remove the duplicate template and make sure the unified template is always used.

@sebastian-meyer sebastian-meyer self-requested a review March 7, 2023 08:12
@sebastian-meyer sebastian-meyer added the ⏳ prototype A provisional pull request still work in progress. label Mar 7, 2023
@sebastian-meyer
Copy link
Member

I think all PRs going to master, and master is merged at regular intervals into 4.x

Yes, that's true until development of a new major version begins. Currently I am working on the 4.1 release, so all pull requests should still target the master branch. After that the next version will be 5.0 (with support for TYPO3 v11) and any upcoming changes to 4.1 should then be targeted at the 4.x branch.

@BFallert BFallert changed the base branch from 4.x to master March 17, 2023 13:15
@sebastian-meyer
Copy link
Member

How should we proceed with this pull request, @BFallert?

@BFallert
Copy link
Collaborator Author

BFallert commented Jun 5, 2023

Please have a look at Resources/Private/Templates/Collection/List.html. This template already contains your proposed additions and is meant to be used with the Collection controller.

But when i clicked on a collection on a page that contains a collection list (plugin: Collection), a normal ListView is called.

I am OK with unifying the templates and using only one template for all cases, but then we need to remove the duplicate template and make sure the unified template is always used.

Small adjustments would probably still have to be made in the existing template.
But I don't know how I can call up the same template from two different situations (collection and listView)?
Can anyone offer support here?

On the other hand, if I'm the only one with this problem, we can close the PR.

@sebastian-meyer
Copy link
Member

On the other hand, if I'm the only one with this problem, we can close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏳ prototype A provisional pull request still work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants