Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility problem with hydrateRowData() #49

Closed
infsy opened this issue Apr 3, 2015 · 4 comments
Closed

Compatibility problem with hydrateRowData() #49

infsy opened this issue Apr 3, 2015 · 4 comments

Comments

@infsy
Copy link

infsy commented Apr 3, 2015

Hi

i just updated my symfony project with this versions

  • Symfony : 2.5.11
  • Doctrine/orm : 2,5,0
  • Kitpages : master

Runtime Notice: Declaration of Kitpages\DataGridBundle\Hydrators\DataGridHydrator::hydrateRowData() should be compatible with Doctrine\ORM\Internal\Hydration\AbstractHydrator::hydrateRowData(array $data, array &$result) in /home/cedric/Programmation/kentel/trunk/vendor/kitpages/data-grid-bundle/Kitpages/DataGridBundle/Hydrators/DataGridHydrator.php line 0

It was functionnal before update.

Any idea ?

@eliecharra
Copy link
Member

@infsy Thanks for you feedback, I'll working on a fix asap

@eliecharra
Copy link
Member

Minor BC BREAK: Custom Hydrators API change

As of 2.5, AbstractHydrator does not enforce the usage of cache as part of API, and now provides you a clean API for column information through the method hydrateColumnInfo($column). Cache variable being passed around by reference is no longer needed since Hydrators are per query instantiated since Doctrine 2.4.

Hum, there is a BC break in doctrine 2.5.
@philippe-levan Ok to realease a 2.5 version of DataGrid following new doctrine 2.5 API ?

eliecharra pushed a commit that referenced this issue Apr 3, 2015
@eliecharra
Copy link
Member

@infsy Could you try with

{
    "require": {
        "kitpages/data-grid-bundle": "~2.5"
    }
}

@infsy
Copy link
Author

infsy commented Apr 3, 2015

@eliecharra
Great ! It works like a charm J

Many thank's for the very quick update !
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants