Skip to content

Commit

Permalink
fix(jupyter): Avoid panicking when DEBUG env var is set (denoland#2…
Browse files Browse the repository at this point in the history
…4168)

Fixes denoland#22050.

It seems very unlikely that a user would be intending to enable deno's
internal debug logs by setting the DEBUG env var. If they really want
that, they can set `RUST_LOG=debug` instead.
  • Loading branch information
nathanwhit committed Jun 10, 2024
1 parent e3b2ee1 commit 7996c0d
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions cli/tools/jupyter/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use crate::tools::repl;
use crate::tools::test::create_single_test_event_channel;
use crate::tools::test::reporters::PrettyTestReporter;
use crate::tools::test::TestEventWorkerSender;
use crate::util::logger;
use crate::CliFactory;
use deno_core::anyhow::Context;
use deno_core::error::generic_error;
Expand Down Expand Up @@ -52,11 +51,6 @@ pub async fn kernel(

let connection_filepath = jupyter_flags.conn_file.unwrap();

// This env var might be set by notebook
if std::env::var("DEBUG").is_ok() {
logger::init(Some(log::Level::Debug));
}

let factory = CliFactory::from_flags(flags)?;
let cli_options = factory.cli_options();
let main_module =
Expand Down

0 comments on commit 7996c0d

Please sign in to comment.