Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spikeling, a neuron model implemented in arduino #140

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

amchagas
Copy link
Contributor

Added Spikeling, a neuron model implemented in arduino

Added Spikeling, a neuron model implemented in arduino
@kasbah kasbah changed the title Update boards.txt Added Spikeling, a neuron model implemented in arduino Jul 10, 2018
@kasbah
Copy link
Member

kasbah commented Jul 10, 2018

Hey Andre! Looks nice, I noticed a couple of things:

  • There is no soldermask or silkscreen. Is this intended?
  • You are making use of the newer CSV support but in a bit of a round about way as the file is still a .tsv. I think maybe I should make the CSV support official and allow .csv and you could rename the file. I think it could also read the .ods or .xlsx. It just doesn't look for those files yet. Which file would you prefer to use?

@amchagas
Copy link
Contributor Author

amchagas commented Jul 10, 2018 via email

@kasbah
Copy link
Member

kasbah commented Jul 11, 2018

Ah, it doesn't pick it up because of the file names. I have never seen anyone use these file names though they are very clear actually. Do you know if they manually renamed them or if they use a common gerber plotter script?

Kitspace uses whats-that-gerber to guess what is what and we have never encountered this file naming style. We either have to add support for it or, if you use the default Eagle or Oshpark plotter script then it will know what is what.

Don't worry about the csv with a tsv extension for now. I'll properly enable CSV in Kitspace soon and then send a pull-request to change the name.

@amchagas
Copy link
Contributor Author

The names are as spit out by Eagle's conversion/export tool. Again, this might have been me clicking something wrong while converting brd to gerber... Should I rename it?

@kasbah
Copy link
Member

kasbah commented Jul 11, 2018

Interesting, where is this in the menu? What version of Eagle is this?

There is nothing wrong with the files. We just don't recognize the names yet.

@amchagas
Copy link
Contributor Author

amchagas commented Jul 13, 2018

I just downloaded the latest version on their website (first time using it actually..)

Is there anything that I should do on my side to finish the upload ? (Peeps in the lab want to start spreading the link :) )

@kasbah
Copy link
Member

kasbah commented Jul 13, 2018

Hold up, I'll fix it.

@kasbah
Copy link
Member

kasbah commented Jul 13, 2018

It'll probably take till monday though. If you can't wait you could use the Oshpark cam job, download it and select it in the popup after doing File -> "Cam Processor".

@amchagas
Copy link
Contributor Author

Hi,
I ended up renaming the files to the kicad convention, hope this solves the issue? (could only setup the oshpark thing to order pcbs from them...)

@kasbah
Copy link
Member

kasbah commented Jul 16, 2018

Oh ok, are you sure you want to do that? Fix is incoming: tracespace/tracespace#76

@kasbah
Copy link
Member

kasbah commented Jul 16, 2018

Well, I'll merge this for now. Feel free to just use the default Eagle names in the future as it should be fixed by then.

@kasbah kasbah merged commit 2c558bb into kitspace:master Jul 16, 2018
@kasbah
Copy link
Member

kasbah commented Jul 16, 2018

@amchagas
Copy link
Contributor Author

amchagas commented Jul 16, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants