Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA]: replace third-party submodules #352

Open
kitsudaiki opened this issue Jun 28, 2024 · 1 comment
Open

[QA]: replace third-party submodules #352

kitsudaiki opened this issue Jun 28, 2024 · 1 comment
Labels
Env: Build-Process in case the build-process has to be updated Env: Documentation requires an update of the documentation L: ★☆☆ Expect low difficulty on hold paused issues QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Security security-bugs
Milestone
backlog core

Comments

@kitsudaiki
Copy link
Owner

QA

Description

There are still 2 submodules used for json and jwt. These have to be replaced by apt-backages too.

Acceptance Criteria

  • json and jwt library were moved from git submodules to apt-package like the other libraries

Additional Information

Blocked by

How to test
@kitsudaiki kitsudaiki added QA Any tasks, witch improve the quality of the code, documentation and so on Env: Documentation requires an update of the documentation Topic: Security security-bugs Env: Build-Process in case the build-process has to be updated L: ★☆☆ Expect low difficulty labels Jun 28, 2024
@kitsudaiki kitsudaiki added this to the 0.5.0 milestone Jun 28, 2024
@kitsudaiki kitsudaiki self-assigned this Jun 28, 2024
kitsudaiki added a commit that referenced this issue Jun 28, 2024
@kitsudaiki
Change (#352): replace json-submodule
b5731a4 
Replaces the json submodule by the apt-package.
@kitsudaiki kitsudaiki mentioned this issue Jul 5, 2024
Merged
kitsudaiki added a commit that referenced this issue Jul 5, 2024
@kitsudaiki
Merge pull request #353 from kitsudaiki/qa/remove-json-submodules
d0ca38c 
related issue: #352
@kitsudaiki
Copy link
Owner Author

only replaced the json-lib so far. The used jwt-lib doesn't exist as upstream apt-packages. There is another jwt-lib, which came with a later ubuntu-version. So this issue is on hold, until the upgrade to a newer ubtuntu base.

@kitsudaiki kitsudaiki added the on hold paused issues label Jul 5, 2024
@kitsudaiki kitsudaiki modified the milestones: 0.5.0, 0.6.0 Jul 6, 2024
@kitsudaiki kitsudaiki removed their assignment Aug 3, 2024
@kitsudaiki kitsudaiki changed the title [QA]: replace submodules [QA]: replace third-party submodules Aug 3, 2024
@kitsudaiki kitsudaiki modified the milestones: 0.6.0, backlog core Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Env: Build-Process in case the build-process has to be updated Env: Documentation requires an update of the documentation L: ★☆☆ Expect low difficulty on hold paused issues QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Security security-bugs
Projects
Hanami
Status: On Hold
Milestone
backlog core
Development

No branches or pull requests
1 participant
@kitsudaiki