New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kotlin #14
Upgrade kotlin #14
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 77.92% 77.92%
Complexity 14 14
=========================================
Files 10 10
Lines 222 222
Branches 37 37
=========================================
Hits 173 173
Misses 28 28
Partials 21 21 Continue to review full report at Codecov.
|
build.gradle
Outdated
} | ||
dependencies { | ||
classpath 'com.android.tools.build:gradle:2.3.3' | ||
classpath 'com.android.tools.build:gradle:3.0.0-rc2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0.0 maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it right away
@@ -18,7 +19,7 @@ allprojects { | |||
ext { | |||
publishVersion = '0.3.0' | |||
|
|||
kotlinVersion = '1.1.4-3' | |||
kotlinVersion = '1.1.51' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
@babedev gently ping! |
build.gradle
Outdated
@@ -3,9 +3,10 @@ | |||
buildscript { | |||
repositories { | |||
jcenter() | |||
google() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is indent here off?
…f/Forge into bd/upgrade-dependencies
Thanks for your contribution! |
Upgrade Kotlin version to 1.1.51 and also Android and Gradle.