Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kotlin #14

Merged
merged 5 commits into from Nov 15, 2017
Merged

Upgrade kotlin #14

merged 5 commits into from Nov 15, 2017

Conversation

babedev
Copy link
Collaborator

@babedev babedev commented Oct 23, 2017

Upgrade Kotlin version to 1.1.51 and also Android and Gradle.

@codecov
Copy link

codecov bot commented Oct 23, 2017

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     77.92%   77.92%           
  Complexity       14       14           
=========================================
  Files            10       10           
  Lines           222      222           
  Branches         37       37           
=========================================
  Hits            173      173           
  Misses           28       28           
  Partials         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521804c...ca38245. Read the comment docs.

build.gradle Outdated
}
dependencies {
classpath 'com.android.tools.build:gradle:2.3.3'
classpath 'com.android.tools.build:gradle:3.0.0-rc2'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0.0 maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it right away

@@ -18,7 +19,7 @@ allprojects {
ext {
publishVersion = '0.3.0'

kotlinVersion = '1.1.4-3'
kotlinVersion = '1.1.51'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kittinunf
Copy link
Owner

@babedev gently ping!

build.gradle Outdated
@@ -3,9 +3,10 @@
buildscript {
repositories {
jcenter()
google()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is indent here off?

@kittinunf
Copy link
Owner

Thanks for your contribution!

@kittinunf kittinunf merged commit 81d1470 into master Nov 15, 2017
@kittinunf kittinunf deleted the bd/upgrade-dependencies branch November 15, 2017 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants