Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 275 download response empty #396

Merged
merged 14 commits into from
Aug 1, 2018

Conversation

markGilchrist
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #396 into master will increase coverage by 0.14%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #396      +/-   ##
============================================
+ Coverage      75.9%   76.05%   +0.14%     
  Complexity      195      195              
============================================
  Files            33       33              
  Lines           963      969       +6     
  Branches        174      175       +1     
============================================
+ Hits            731      737       +6     
  Misses          146      146              
  Partials         86       86
Impacted Files Coverage Δ Complexity Δ
...kotlin/com/github/kittinunf/fuel/util/Delegates.kt 83.33% <ø> (ø) 0 <0> (ø) ⬇️
.../kittinunf/fuel/core/requests/UploadTaskRequest.kt 86.53% <100%> (+0.26%) 3 <0> (ø) ⬇️
...lin/com/github/kittinunf/fuel/util/InputStreams.kt 91.66% <100%> (+2.77%) 0 <0> (ø) ⬇️
...ittinunf/fuel/core/requests/DownloadTaskRequest.kt 81.81% <100%> (+4.04%) 4 <0> (ø) ⬇️
.../kotlin/com/github/kittinunf/fuel/core/Response.kt 68.88% <20%> (ø) 20 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a47432...f058f32. Read the comment docs.

Copy link
Owner

@kittinunf kittinunf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kittinunf
Copy link
Owner

Can you try to update against latest master though?

@markGilchrist markGilchrist merged commit 18bb9a9 into master Aug 1, 2018
@markGilchrist markGilchrist deleted the Issue_275_Download_response_empty branch August 1, 2018 07:04
@kittinunf kittinunf mentioned this pull request Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants