Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Result version #540

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Update Result version #540

merged 1 commit into from
Nov 19, 2018

Conversation

kittinunf
Copy link
Owner

@kittinunf kittinunf commented Nov 19, 2018

Description

These PR updates Result library to 2.0.0 so that it uses Kotlin 1.3.+ across the board.

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #540   +/-   ##
=========================================
  Coverage     73.44%   73.44%           
  Complexity      302      302           
=========================================
  Files            48       48           
  Lines          1235     1235           
  Branches        184      184           
=========================================
  Hits            907      907           
  Misses          245      245           
  Partials         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4683cee...d38f403. Read the comment docs.

@SleeplessByte SleeplessByte added the 💎 feature New feature label Nov 19, 2018
@SleeplessByte SleeplessByte added this to the Fuel 2.0 milestone Nov 19, 2018
@iNoles iNoles merged commit 0a90799 into master Nov 19, 2018
@iNoles iNoles deleted the kv/upgrade-result branch November 19, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants