Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuel-core] Update Content Type regex to better match spec #673

Merged
merged 2 commits into from Aug 11, 2019
Merged

[fuel-core] Update Content Type regex to better match spec #673

merged 2 commits into from Aug 11, 2019

Conversation

ProjectZed
Copy link

@ProjectZed ProjectZed commented Aug 10, 2019

Description

Replaced the required space regex with an optional space regex.
Fixes #671

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

Matching "application/json; charset=utf-8" and "application/json;charset=utf-8" with a regex tester
https://regex101.com/r/tpBlL3/1

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@ProjectZed ProjectZed changed the title [fuel-core] Update Content Type regex to better follow spec [fuel-core] Update Content Type regex to better match spec Aug 10, 2019
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #673   +/-   ##
=========================================
  Coverage     71.32%   71.32%           
  Complexity      296      296           
=========================================
  Files            58       58           
  Lines          1496     1496           
  Branches        194      194           
=========================================
  Hits           1067     1067           
  Misses          334      334           
  Partials         95       95
Impacted Files Coverage Δ Complexity Δ
...m/github/kittinunf/fuel/core/BodyRepresentation.kt 75% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3786703...868b5fd. Read the comment docs.

Copy link
Collaborator

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the best! Thank you ❤️

@SleeplessByte SleeplessByte merged commit 76b08a4 into kittinunf:master Aug 11, 2019
@kittinunf
Copy link
Owner

@ProjectZed 🍻

@ProjectZed ProjectZed deleted the media-type-regex-fix branch August 11, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application/json;charset=utf-8 doesn't match expected text content type regex
3 participants