Customized HttpResponse Per Platforms #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittinunf
reviewed
May 4, 2023
|
Looks okay to me! Wondering whether we should still have a common field for something that share across the whole different platforms? e.g. statusCode, possibly more in the future. |
I don't think that is possible for now. |
kittinunf
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am putting HttpResponse into expect/actual class because I knew an interface will be extremely messy for this. It will be very easier to customize it on each platform. I knew the string will be extremely inefficient for large files, so I wanted to give developers better control to handle data how they wanted.
Breaking Change: body in HttpResponse for JVM is ResponseBody.