Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Kotlinx-io #926

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Implement Kotlinx-io #926

merged 7 commits into from
Jul 23, 2024

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented Jun 29, 2024

Kotlinx-io simplified the io code that cut down some expect/actual classes into once

@iNoles iNoles requested a review from kittinunf June 29, 2024 21:20
@iNoles iNoles self-assigned this Jun 29, 2024
@iNoles iNoles linked an issue Jun 29, 2024 that may be closed by this pull request
@iNoles iNoles removed the request for review from kittinunf June 29, 2024 21:21
@iNoles iNoles requested a review from kittinunf June 30, 2024 12:45

public fun <T : Any> HttpResponse.toForge(deserializer: JSON.() -> DeserializedResult<T>): DeserializedResult<T> =
Forge.modelFromJson(body.string(), deserializer)
Forge.modelFromJson(source.readString(), deserializer)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kittinunf
Copy link
Owner

I think this is amazing! 💯 👍 Great job

@kittinunf kittinunf merged commit 300690b into main Jul 23, 2024
7 checks passed
@iNoles iNoles deleted the kotlinx-io branch July 23, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration with IO multiplatform library
2 participants