Fixed webpack to close with kitto.server #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--stdin` flag wasn't added until a later version that the default for webpack-dev-server. This is meant as a hotfix for the larger task of updating Webpack.
|
@davejlong This means c3bdd31 has broken the behaviour where killing The easy fix is to bump webpack-dev-server to @1.15.0. Can you change it from this PR? |
zorbash
reviewed
Oct 25, 2017
| @@ -3,7 +3,7 @@ defmodule Mix.Tasks.Kitto.Server do | |||
| require Logger | |||
|
|
|||
| @watchers webpack: [bin: "./node_modules/.bin/webpack-dev-server", | |||
| opts: ["--stdin", "--progress"]] | |||
| opts: ["--watch", "--progress", "--colors"]] | |||
There was a problem hiding this comment.
I cannot find the --watch and --colors options.
There's --color though, which appears in
https://github.com/webpack/webpack-dev-server/blob/v2.2.0/bin/webpack-dev-server.js#L91
is not compatible with webpack <= 2.0.0 will you also push changes to bump https://github.com/kittoframework/kitto/blob/master/installer/templates/new/package.json#L25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--stdinflag wasn't added until a later version that the default for webpack-dev-server. This is meant as a hotfix for the larger task of updating Webpack.