-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renamed text job to phrases for easier comprehension #85
Conversation
some more background can be found on Gitter where @davejlong and I discussed this topic. Thanks Dave! |
3 similar comments
@zorbash if you want me to clean this up with a new PR let me know. I tested my initial changes but it was working because I hadn't changed the dashboard and job to match. Fixed now. |
@@ -3,5 +3,5 @@ use Kitto.Job.DSL | |||
job :text, every: {4, :seconds} do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the job to :phrases
and remove the 1st argument which isn't required anymore from broadcast.
job :phrases, every: {4, :seconds} do
# ...
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
when I first looked at Kitto I looked at the text widget and didn't quite grok the relationship between a widget, a job and the dashboard. Part of this was because the job was named
text
as was the widget (wellText
I guess technically).I simply renamed
text.exs
tophrases.exs
and changed the installer template so now the text widget on the sample dashboard is similar to the other widgets where the widget name is different than the job name (`data-source="phrases" in the dashboard).It's a small change but I think could help.