Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CssMin does not preserve license comments #8

Open
kittsville opened this issue Jun 17, 2015 · 1 comment
Open

CssMin does not preserve license comments #8

kittsville opened this issue Jun 17, 2015 · 1 comment

Comments

@kittsville
Copy link
Owner

While JShrink is capable to being configured to preserve comment blocks starting with /*!, thus allowing for licensing information to be preserved, it seems CssMin cannot. This is not good seeing as removing that stuff is illegal/immoral. I'm pretty sure nobody but me has ever visited WP-Librarian's repo page, let alone the Dev Kit's page, but that doesn't mean I should start dicking with other people's code.

To keep things legal in the meantime I've set CssMin to preserve all commens (see 123b82e). While this'll add a minor overhead it doesn't really matter because WP-Librarian is still a long way from a production release.

@kittsville
Copy link
Owner Author

Marked as long term because I probably won't bother trying to fix this for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant