Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Enable the PhoenixRedis repo to compile (including test cases) #6

Closed
dfirsht opened this issue Feb 8, 2016 · 3 comments
Closed
Milestone

Comments

@dfirsht
Copy link
Contributor

dfirsht commented Feb 8, 2016

Issue by ricardo-olivieri
Wednesday Jan 06, 2016 at 23:04 GMT
Originally opened as https://github.ibm.com/ibmswift/Phoenix/issues/6


Also, let's move the test cases for Redis into the new repo for Redis.

@dfirsht dfirsht added this to the 0.2 milestone Feb 8, 2016
@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by KALLNER
Tuesday Jan 19, 2016 at 21:37 GMT


A few things:

  1. The tests weren't copied
  2. The PhoenixTest framework needs to be a test dependency
  3. The sources should be under Sources
  4. The buildTests shell script should be copied into the repo

Was the code built? The last time I tried, it seemed that it needed the sys library from Phoenix.

@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by rfdickerson
Thursday Jan 21, 2016 at 15:41 GMT


What's the progress on this? Currently Redis tests are trying to be run in the Phoenix project, but they are causing the testcase compilation to fail. Should I take this ticket?

@dfirsht
Copy link
Contributor Author

dfirsht commented Feb 8, 2016

Comment by rfdickerson
Thursday Jan 21, 2016 at 17:04 GMT


@KALLNER : I completed

  • The tests copied from Phoenix to PhoenixRedis
  • The PhoenixTest framework added as a test dependency
  • The sources are now located under Sources
  • The buildTests shell script copied into the repo

However, sys module in Phoenix is still needed to compile this. Please advise how to get this working. Should I make Phoenix a dependency of PhoenixRedis?

@dfirsht dfirsht closed this as completed Feb 8, 2016
@casamm casamm mentioned this issue Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant