New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration mixins for allauth #60
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhelba
reviewed
Sep 24, 2020
brianhelba
reviewed
Sep 24, 2020
brianhelba
approved these changes
Sep 24, 2020
I don't have permission to merge. |
brianhelba
reviewed
Sep 28, 2020
brianhelba
reviewed
Sep 28, 2020
brianhelba
reviewed
Sep 28, 2020
brianhelba
reviewed
Sep 28, 2020
brianhelba
reviewed
Sep 28, 2020
brianhelba
reviewed
Sep 28, 2020
brianhelba
reviewed
Sep 28, 2020
brianhelba
reviewed
Sep 30, 2020
brianhelba
previously approved these changes
Sep 30, 2020
jbeezley
force-pushed
the
allauth
branch
2 times, most recently
from
October 6, 2020 17:35
3e2313a
to
2194b1a
Compare
brianhelba
reviewed
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this here for discussion. I'm not sure where to divide settings that go here vs. in the cookiecutter example. What is here provides authentication related views (sign up, login, change password, verify email, etc.) that works fairly seemlessly with Google OAuth. A few things have to be manually configured that can be documented in the cookiecutter.
From there, the server rendered views (e.g. http://localhost:8000/accounts/login/) work as expected.
What doesn't work is the redirection after login, which defaults to the non-existent
/accounts/profile
page. I'm not sure how to handle this in general as the SPA client will want to have control over it. We could store the desired redirect target in a cookie or the oauth state, as we've done elsewhere. In any case, that code probably belongs here.To what degree do we want to make decisions about defaults here? Should we even add the google provider at all? Should it be a different mixin?
Another question is about styling the templates... should this library attempt to make the pages look okay, or is that purely a concern for the consumer?