Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration mixins for allauth #60

Closed
wants to merge 3 commits into from

Conversation

jbeezley
Copy link

Putting this here for discussion. I'm not sure where to divide settings that go here vs. in the cookiecutter example. What is here provides authentication related views (sign up, login, change password, verify email, etc.) that works fairly seemlessly with Google OAuth. A few things have to be manually configured that can be documented in the cookiecutter.

  1. Configure the site at http://localhost:8000/admin/sites/site/
  2. Configure the Google oauth at http://localhost:8000/admin/socialaccount/socialapp/

From there, the server rendered views (e.g. http://localhost:8000/accounts/login/) work as expected.

What doesn't work is the redirection after login, which defaults to the non-existent /accounts/profile page. I'm not sure how to handle this in general as the SPA client will want to have control over it. We could store the desired redirect target in a cookie or the oauth state, as we've done elsewhere. In any case, that code probably belongs here.

To what degree do we want to make decisions about defaults here? Should we even add the google provider at all? Should it be a different mixin?

Another question is about styling the templates... should this library attempt to make the pages look okay, or is that purely a concern for the consumer?

@jbeezley
Copy link
Author

I don't have permission to merge.

brianhelba
brianhelba previously approved these changes Sep 30, 2020
@jbeezley jbeezley force-pushed the allauth branch 2 times, most recently from 3e2313a to 2194b1a Compare October 6, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants