Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend_to gives error if n_samples is already correct #972

Open
sammlapp opened this issue Apr 8, 2024 · 0 comments
Open

extend_to gives error if n_samples is already correct #972

sammlapp opened this issue Apr 8, 2024 · 0 comments
Assignees
@sammlapp
Labels
bug Something isn't working resolved_in_develop The issue has been resolved in the develop branch but not in master
Milestone
0.11.0

Comments

@sammlapp
Copy link
Collaborator

sammlapp commented Apr 8, 2024

opensoundscape/opensoundscape/audio.py

Line 609 in 379952a

elif target_n_samples < current_n_samples:

if n_target_samlpes==current_n_samples, new_samples is not assigned
@sammlapp sammlapp added the bug Something isn't working label Apr 8, 2024
sammlapp added a commit that referenced this issue Apr 8, 2024
@sammlapp
fix extend_to resolves #972 and #948
98704d4 
changes the behavior of extend_to() so that it doesn't trim audio
sammlapp added a commit that referenced this issue Apr 8, 2024
@sammlapp
fix extend_to resolves #972 and #948
f1dfaed 
changes the behavior of extend_to() so that it doesn't trim audio
@sammlapp sammlapp added the resolved_in_develop The issue has been resolved in the develop branch but not in master label Apr 12, 2024
@sammlapp sammlapp added this to the 0.11.0 milestone Apr 12, 2024
@sammlapp sammlapp self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sammlapp sammlapp

Labels
bug Something isn't working resolved_in_develop The issue has been resolved in the develop branch but not in master
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
1 participant
@sammlapp