-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed - preprocess - actions #570
Conversation
…undscape into issue_477_pandas_native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that the desired changes should be made throughout the codebase before closing this issue or merging a branch.
One general thought after reviewing is that as a user, I would not be sure how to set random seeds to ensure reproducibility. Internally, several different packages generate random numbers, so the user would need to set random seeds for random, pandas, torch, and potentially numpy as well. I'm not sure what to do about this, but I'll create a separate issue for it.
The code to set seeds for all random methods across packages is a set of 4-5 statements that we can include in the documentation. Regarding the modifications, on second thought, instead of doing a sweep across the entire codebase, we could do it module wise with proper testing to ensure minimal risk. Have completed |
If this work is complete, please change the PR from 'draft' to ready |
Resolution for #477 - fix verified using preprocessor tutorial.