Support writing mp3 (soundfile 0.11) #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the field name in metadata from 'audiomoth_id' to 'device_id', this resolves #446. I also changed the format to keep the entire name, for instance "AudioMoth 24526B065D325963", rather than just the number. This avoids possible confusion with device IDs of other ARU types.
this was called for the tinytag output but is incorrect for soundfile, which already returns a dictionary
The CI is failing because `sudo apt-get install libsndfile1` is installing 1.0.31 and needs to install 1.1.0
writing mp3 is only supported by libsndfile >=1.1.0, which is not yet available on Ubuntu. We'll allow the user to try writing any file type, but provide a helpful error message if soundfile.write raises a cryptic ValueError (which happens if libsndfile <1.1.0 and you try to write a .mp3 file, for instance)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switches from tinytag to soundfile for loading metadata (to match how we write metadata)