Issue 930 localization bug #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammlapp
requested changes
May 9, 2024
There was a problem hiding this comment.
please add tests that check the desired behaviors: (the checks should fail on the pre-PR code and succeed using the code in this PR)
- localize() with receivers <ndim+1 returns none
- estimate_location() with too few receivers returns None and sets attributes to None
explicitly test that the events are "unlocalized" if they don't have enough recorders above cc_threshold to meet min_n_receivers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #930 - the problem of producing position estimates even when fewer than minimim_number_ARUs are above the cc_threshold.