Merge pull request #112 from kiudee/fix_noise_tell

Fix model not being informed about noise variance
kiudee · Nov 22, 2020 · 2281ca0 · 2281ca0
2 parents 8706ac2 + b89c29f
commit 2281ca0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -1,6 +1,11 @@
 =======
 History
 =======
+0.7.0-beta.3 (2020-11-22)
+-------------------------
+* Fix a bug where the model was not informed about the estimated noise variance
+  of the current match.
+
 0.7.0-beta.2 (2020-10-13)
 -------------------------
 * Revert default acquisition function back to ``"mes"``.

diff --git a/tune/cli.py b/tune/cli.py
@@ -469,21 +469,14 @@ def local(  # noqa: C901
                 if opt.gp.chain_ is None:
                     gp_burnin = settings.get("gp_initial_burnin", gp_initial_burnin)
                     gp_samples = settings.get("gp_initial_samples", gp_initial_samples)
-                    opt.tell(
-                        point,
-                        score,
-                        n_samples=n_samples,
-                        gp_samples=gp_samples,
-                        gp_burnin=gp_burnin,
-                    )
-                else:
-                    opt.tell(
-                        point,
-                        score,
-                        n_samples=n_samples,
-                        gp_samples=gp_samples,
-                        gp_burnin=gp_burnin,
-                    )
+                opt.tell(
+                    point,
+                    score,
+                    noise_vector=error,
+                    n_samples=n_samples,
+                    gp_samples=gp_samples,
+                    gp_burnin=gp_burnin,
+                )
                 later = datetime.now()
                 difference = (later - now).total_seconds()
                 root_logger.info(f"GP sampling finished ({difference}s)")