Skip to content

Commit

Permalink
Merge pull request #114 from kiudee/fix_error_bars
Browse files Browse the repository at this point in the history
Correctly output standard deviation instead of variance for score estimate
  • Loading branch information
kiudee committed Dec 8, 2020
2 parents 2bd28ee + 71f5f3e commit cd01b72
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
History
=======

0.7.1 (2020-12-08)
------------------
* Fix incorrectly outputting the variance instead of the standard deviation for
the estimated error around the score estimate.

0.7.0 (2020-11-22)
------------------
* Fix a bug where the model was not informed about the estimated noise variance
Expand Down
8 changes: 4 additions & 4 deletions tune/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,8 @@ def local( # noqa: C901
difference = (later - now).total_seconds()
root_logger.info(f"Experiment finished ({difference}s elapsed).")

score, error = parse_experiment_result(out_exp, **settings)
root_logger.info("Got score: {} +- {}".format(score, error))
score, error_variance = parse_experiment_result(out_exp, **settings)
root_logger.info("Got score: {} +- {}".format(score, np.sqrt(error_variance)))
root_logger.info("Updating model")
while True:
try:
Expand All @@ -472,7 +472,7 @@ def local( # noqa: C901
opt.tell(
point,
score,
noise_vector=error,
noise_vector=error_variance,
n_samples=n_samples,
gp_samples=gp_samples,
gp_burnin=gp_burnin,
Expand Down Expand Up @@ -506,7 +506,7 @@ def local( # noqa: C901
break
X.append(point)
y.append(score)
noise.append(error)
noise.append(error_variance)
iteration = len(X)

with AtomicWriter(data_path, mode="wb", overwrite=True).open() as f:
Expand Down

0 comments on commit cd01b72

Please sign in to comment.