Switch data format to hdf5 #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an old npz file is detected it will be loaded and converted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the data format from compressed NumPy arrays to HDF5. The old format is still supported in that it will be read and converted.
Motivation
Saving to NumPy arrays is problematic, since saving categorical values requires saving objects. Reading NumPy arrays containing objects can be a security risk.
.csvfiles are convenient in that they can be opened with a text editor, but it’s not possible to save arbitrary data of different length.HDF5 is useful in that it can store several tables of data, which could be useful in the future.
Issues
Fixes #90