Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular #58

Merged
5 commits merged into from
May 7, 2014
Merged

Circular #58

5 commits merged into from
May 7, 2014

Conversation

gxxcastillo
Copy link
Contributor

Prevent problems when serializing a model or collection that contains circular references

uglymunky added 5 commits May 2, 2014 15:54
comment out dist tests
e2771c0
Update cached models and collections instead of replacing them.
9c1eb82 
This also takes into account that collections can be either "current" or "self".

New methods:
store.getCurrentCollection()
bbSiren.parseModel()
bbSiren.parseCollection()
Bug fixes
7f8bd44 
New methods:
Model.update()
Collection.update()
bbSiren.addModelToStore()
bbSiren.addCollectionToStore()
Fix .update() methods
b11f9a1
#56 - Prevent errors when serializing objects with circular references
2bcd646
@gxxcastillo
Copy link
Contributor Author

This should be merged after #57

@gxxcastillo gxxcastillo assigned ghost May 6, 2014
@gxxcastillo gxxcastillo mentioned this pull request May 6, 2014
Merged
ghost pushed a commit that referenced this pull request May 7, 2014
Merge pull request #58 from kiva/circular
362e9f3 
Circular
@ghost ghost merged commit 362e9f3 into pre-release May 7, 2014
@ghost ghost deleted the circular branch May 7, 2014 21:46
@darcman darcman unassigned ghost May 20, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gxxcastillo