Allow last request to be aborted #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -630,8 +630,6 @@ _.extend(BbSiren, { | |||
|
|
|||
|
|
|||
| /** | |||
| * @todo is this even being used? | |||
There was a problem hiding this comment.
yes, in BbSiren.resolveOne
|
One thing to note is that aborting a jqXHR will result in an error being triggered, so we probably want to handle that gracefully on the client. If you find that to be troublesome to handle, you can call open() on an already opened request and that will abort it as well, but suppress the error. |
|
Leaving branch for you to delete @emuvente since you might want to revisit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Backbone.Siren does not save a reference to the jqXHR object from the request when it resolves a url. This pull request brings in a way (albeit an ugly way) to save the jqXHR object. This pull request also adds a method to abort the last request, which is only possible once the jqXHR object from the last request is being saved.