Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue 1029 move update search state method to new src utils loan search utils js file #3815

Merged
merged 5 commits into from
May 17, 2022
Merged

Vue 1029 move update search state method to new src utils loan search utils js file #3815

merged 5 commits into from
May 17, 2022

Conversation

dyersituations
Copy link
Collaborator

https://kiva.atlassian.net/browse/VUE-1029

  • Created new util file
  • Added associated tests file
  • Fixed a couple vue errors from previous PRs
  • Loans still appearing in search like before
  • Added missing auth0 mock for local dev that was causing an error

image

mcstover
mcstover reviewed May 16, 2022
View reviewed changes
src/util/KvAuth0.js Outdated Show resolved Hide resolved
@dyersituations dyersituations merged commit bc9a6e3 into main May 17, 2022
@dyersituations dyersituations deleted the VUE-1029-move-update-search-state-method-to-new-src-utils-loan-search-utils-js-file branch May 17, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcstover mcstover mcstover approved these changes

@georgebs georgebs Awaiting requested review from georgebs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dyersituations @mcstover