Nova ocorrencia #163
Closed
Nova ocorrencia #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 19, 2017
| @@ -70,6 +70,8 @@ class Pagamento | |||
| attr_accessor :data_multa | |||
| # <b>OPCIONAL</b>: Número da Parcela | |||
| attr_accessor :parcela | |||
| # <b>OPCIONAL</b>: Código de protesto | |||
There was a problem hiding this comment.
Use only ascii symbols in comments.
| # Preencher de acordo com o código informado na posição 221. | ||
| # Para código '1' – é possível, de 6 a 29 dias, 35o, 40o, dia corrido. | ||
| # Para código '2' – é possível, 3o, 4o ou 5o dia útil. | ||
| # Para código '3' preencher com Zeros. | ||
| segmento_p << '00' # dias para protesto 2 * | ||
| segmento_p << pagamento.dias_protesto # dias para protesto 2 * |
There was a problem hiding this comment.
Line is too long. [117/80]
| @@ -226,12 +226,12 @@ def monta_segmento_p(pagamento, nro_lote, sequencial) | |||
| # No caso de carteira 31 ou carteira 11/17 modalidade Vinculada, | |||
| # se não informado nenhum código, | |||
| # o sistema assume automaticamente Protesto em 3 dias úteis. | |||
| segmento_p << '3' # cod. para protesto 1 * | |||
| segmento_p << pagamento.codigo_protesto # cod. para protesto 1 * | |||
There was a problem hiding this comment.
Unnecessary spacing detected.
Line is too long. [117/80]
| @@ -156,7 +156,7 @@ def monta_segmento_p(pagamento, nro_lote, sequencial) | |||
| # 30 – Recusa da Alegação do Sacado, | |||
| # 31 – Alteração de Outros Dados, | |||
| # 40 – Alteração de Modalidade. | |||
| segmento_p << '01' # cod. movimento remessa 2 | |||
| segmento_p << pagamento.identificacao_ocorrencia || '01' # cod. movimento remessa 2 | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [113/80]
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.