Fix INSTALL_PRETTYLIB.sh installer #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was the last of them. Thanks for providing the fixes in such a clear and good manner. Top $$$ @taskula |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTALL_PRETTYLIB.sh was broken in a couple of ways.
cpanfileis located undertransformer/, and the installer script attempts to seek cpanfile from current path.. This PR aims to fix installer's paths.cpanfilecontains Debian package dependencies. AFAIK this is not allowed bycpanfileformat (nor is cpanm's function either).The installer crashes when you have those two lines in there.
3. Adds
chmod +x INSTALL_PRETTYLIB.sh.4. Fixes a broken path
PrettyLibExtractor->PrettyExtractor