Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildozer downloads Android SDK 20 during every call to deploy app #137

Closed
matthew-egbert opened this issue Aug 9, 2014 · 3 comments
Closed

Comments

@matthew-egbert
Copy link

Every time I run

buildozer --verbose android deploy

...it downloads the Android SDK

Installing Archives:
Preparing to install archives
Downloading Android SDK Build-tools, revision 20
(22%, 528 KiB/s, 30 seconds left)

Which takes a while and seems unnecessary. Anyone know why?

@monkut
Copy link

monkut commented Aug 20, 2014

same here.

Checked ~/.buildozer directory and in the android/platform directory is "android-sdk-21", but no 20.

monkut pushed a commit to monkut/buildozer that referenced this issue Aug 21, 2014
Found some issues in the way version compare was being performed.

Issue 1. _find_latest_package() included the "key" in the resulting versions list.
    ver = "build-tools-20.0.0"
    v_build_tools = "20.0.0"
    ver > v_build_tools
    --> True

Issue 2. String comparison is being performed.
    It appears to have worked ok so far, but strings do not evaulate like numbers.

    v4_2_2 = "4.2.2"
    v4_2_16 = "4.2.16"
    v4_2_2 > v4_2_16
    --> True

    Updated code to parse version_string to list of ints, for example "4.2.2" --> [4,2,2]
    Note this implementation assumes versions are the same length.
@monkut
Copy link

monkut commented Aug 21, 2014

My fix seems to be working ok here. only one file in buildozer, android.py, needs to be updated.

https://github.com/monkut/buildozer

@tito
Copy link
Member

tito commented Sep 22, 2014

@monkut Could you make a PR for it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants