Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes coveralls.io on pull requests #1063

Merged

Conversation

AndreMiras
Copy link
Member

@AndreMiras AndreMiras commented Apr 10, 2020

This is some tests and not supposed to be merged until completed Completed!

Coveralls.io now runs on pull requests as well.
The report is automatically uploaded on coveralls.io however it needs to be accessed by copying the report URL to review it.
Next up would be to have it commenting on the pull request to see on first sight if it increased or decreased.
Also made a couple of adjustment to the workflow file to clarify between requirements building, Docker build/run and actual testing.

@AndreMiras AndreMiras force-pushed the feature/coveralls_from_pull_requests branch 5 times, most recently from e2440d5 to f5b8351 Compare April 10, 2020 21:15
@AndreMiras AndreMiras changed the title WIP: Trying to workaround token not available on PR (TODO) Playing/Trying to workaround token not available on PR Apr 10, 2020
@AndreMiras AndreMiras force-pushed the feature/coveralls_from_pull_requests branch from f5b8351 to 5c02f85 Compare April 10, 2020 21:20
@AndreMiras AndreMiras changed the title (TODO) Playing/Trying to workaround token not available on PR WIP: Trying to workaround token not available on PR Apr 10, 2020
@AndreMiras AndreMiras force-pushed the feature/coveralls_from_pull_requests branch 17 times, most recently from 9392740 to db103e6 Compare April 10, 2020 23:41
Coveralls.io now runs on pull requests as well.
The report is automatically uploaded on coveralls.io however it needs to
be accessed by copying the report URL to review it.
Next up would be to have it commenting on the pull request to see on
first sight if it increased or decreased.
Also made a couple of adjustment to the workflow file to clarify between
requirements building, Docker build/run and actual testing.
@AndreMiras AndreMiras force-pushed the feature/coveralls_from_pull_requests branch from db103e6 to 3f1b44d Compare April 10, 2020 23:55
@AndreMiras AndreMiras changed the title WIP: Trying to workaround token not available on PR Fixes coveralls.io on pull requests Apr 10, 2020
@AndreMiras AndreMiras requested a review from opacam April 11, 2020 00:33
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@AndreMiras AndreMiras merged commit 422f951 into kivy:master Apr 13, 2020
@AndreMiras AndreMiras deleted the feature/coveralls_from_pull_requests branch April 13, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants