New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garden requirements #41
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0970738
Allow specifying garden packages in buildozer.spec
LilyFoote 0bec489
Specify cwd for garden cmd. Use --app arg.
LilyFoote dd7a2fd
Install garden packages listed in buildozer.spec.
LilyFoote 61e5349
Ensure garden script is available.
LilyFoote f05587e
Merge remote-tracking branch 'origin/garden_requirements' into garden…
LilyFoote f7783a0
Remove garden script from tools.
LilyFoote 22c0ee1
Use kivy-garden's version of garden.
LilyFoote 81619b0
Specify version of garden to use.
LilyFoote 19845cb
Use garden version 0.1.1.
LilyFoote df02289
Merge branch 'master' into garden_requirements
LilyFoote 3e6ee48
Use Garden package from PyPI instead of github
LilyFoote File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to make the appropriate changes to let the garden packages in _applibs instead of libs. If you are afraid about the conflict with standard lib, then let's do _applibs/garden and _applibs/system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed in irc, I think this would require changes to kivy and garden as well as buildozer. I would prefer to stay with this solution and re-think later if it causes any issues.