_get_config_list() was incorrectly returning [""] instead of [] for blank config lists #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g [""] Filter this out when checking permission validity, and when building --permission command line args Also fix two typos in the error message for an unknown permission
…ll string [""]" This reverts commit aa0a7f8.
…lank config lists
For any other value of source.dir presplash and icon were broken.
|
There is 2 changes on the repo, and i don't understand both of them. the "../../../" is wrong, i think the error is elswhere. I'll check it right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a bug in _get_config_list() which only caused problems if you left a config list completely blank, for example,
or