Removed Python 2 support #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops system, host and target Python 2 support. Note a lot of recipes were having hardcoded reference to `lib/python2.7/site-packages/` directory. I suspect most of theses were not working, but the reference has been updated to `lib/python3.7/site-packages/` following the same hardcoding pattern. In follow up work we would do a walkthrough each recipes to fix at least compilation time issues. Also note the `rebuild_updated_recipes.py` is expected to fail as this is touching many recipes including recipes that were already broken.
|
I could successfully build and run a simple project still. But if someone else can also give it a try after installing it from my fork: |
|
Moving forward with it as I have other pending work that would conflict on this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops system, host and target Python 2 support.
Note a lot of recipes were having hardcoded reference to
lib/python2.7/site-packages/directory. I suspect mostof theses were not working, but the reference has been updated
to
lib/python3.7/site-packages/following the same hardcodingpattern. In follow up work we would do a walkthrough each recipes
to fix at least compilation time issues.
Also note the
rebuild_updated_recipes.pyis expected to fail asthis is touching many recipes including recipes that were already
broken.