Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpi for latest iPhone models #707

Merged
merged 2 commits into from May 13, 2022
Merged

Update dpi for latest iPhone models #707

merged 2 commits into from May 13, 2022

Conversation

akshayaurora
Copy link
Member 

    @"iPhone13,1": @476,
    @"iPhone13,2": @460,
    @"iPhone13,3": @458,
    @"iPhone13,4": @458,
    @"iPhone14,2": @460,
    @"iPhone14,3": @460,
    @"iPhone14,4": @476,
    @"iPhone14,5": @460,
    @"iPhone14,6": @326,

@akshayaurora
Update api for latest iPhone models
bf66972 
        @"iPhone13,1": @476,
        @"iPhone13,2": @460,
        @"iPhone13,3": @458,
        @"iPhone13,4": @458,
        @"iPhone14,2": @460,
        @"iPhone14,3": @460,
        @"iPhone14,4": @476,
        @"iPhone14,5": @460,
        @"iPhone14,6": @326,
@akshayaurora akshayaurora requested a review from misl6 May 12, 2022 19:36
@akshayaurora akshayaurora changed the title Update api for latest iPhone models Update dpi for latest iPhone models May 12, 2022
misl6
misl6 reviewed May 12, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that a couple of values are not consistent with https://github.com/lmirosevic/GBDeviceInfo/blob/master/GBDeviceInfo/GBDeviceInfo_iOS.m

Is it a typo or is something expected?

kivy_ios/recipes/ios/src/ios_utils.m Show resolved Hide resolved
kivy_ios/recipes/ios/src/ios_utils.m Outdated Show resolved Hide resolved
kivy_ios/recipes/ios/src/ios_utils.m Outdated Show resolved Hide resolved
@akshayaurora akshayaurora requested a review from misl6 May 12, 2022 23:36
misl6
misl6 approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@misl6 misl6 merged commit e5e4775 into master May 13, 2022
@akshayaurora akshayaurora deleted the latest_models_ppi branch May 13, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akshayaurora @misl6