Fixes some E275 - assert is a keyword #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
misl6
commented
Sep 3, 2022
misl6
commented
- Assert is a keyword and a space is needed + the parentheses are not needed.
- A recent change in pycodestyle (See: Generalize E275 to require space after all keywords, not just "import". PyCQA/pycodestyle#1063) introduced this check.
- CI runs started to fail recently
AndreMiras
added a commit
that referenced
this pull request
Sep 3, 2022
The #746 got me curious about the current linting state. Addressed few low hangging fruits. Removed no longer relevant/addressed ignore rules.
AndreMiras
added a commit
that referenced
this pull request
Sep 3, 2022
The #746 PR got me curious about the current linting state. Addressed few low hangging fruits. Removed no longer relevant/addressed ignore rules.
AndreMiras
added a commit
that referenced
this pull request
Sep 3, 2022
The #746 PR got me curious about the current linting state. Addressed few low hanging fruits. Removed no longer relevant/addressed ignore rules.
AndreMiras
added a commit
that referenced
this pull request
Sep 3, 2022
The #746 PR got me curious about the current linting state. Addressed few low hanging fruits. Removed no longer relevant/addressed ignore rules.
AndreMiras
added a commit
that referenced
this pull request
Sep 3, 2022
The #746 PR got me curious about the current linting state. Addressed few low hanging fruits. Removed no longer relevant/addressed ignore rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.