Disable SDL2 hidapi in order to avoid dependency on CoreBluetooth
#779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kivy does not make use of SDL2 hidapi, and building it into our artifacts requires to link against the
CoreBluetoothframework.More importantly, Apple notices it just after the submission to the App Store, and requests the developer to explain the user why the access to this feature / data is needed via
NSBluetoothPeripheralUsageDescriptionandNSBluetoothAlwaysUsageDescriptionkeys.SDL refers to this issue here, and suggests to disable the HIDAPI via
SDL_HIDAPI_DISABLED:https://github.com/libsdl-org/SDL/blob/07d0f51fa292895443f563f0cbde4cb3802d87fa/include/SDL_hidapi.h#L56-L60