New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for upstream issues with compiler path #866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, easy enough hack (once you know the bug) yet effective.
Do you mind updating the docstring with the reference to the upstream bug?
Hi @tcaduser and @AndreMiras, how about applying the patches from python/cpython#96399 instead? |
Yes I thought it would be cleaner to patch cpython, but I assumed it would be a lot harder as I didn't realized it already existed. |
Hi @misl6, @AndreMiras, I just reviewed the upstream patch. It will still do the wrong thing for my original case:
Their patch is to perform a wildcard search for Please let me know if you still want my fix and I'll incorporate the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments and thanks for reviewing the upstream patch.
Maybe you could share them that valuable feedback.
PR is good for a merge to me, but I leave @misl6 having the final word for it.
Ok, let's merge it while they sort it out on their side. 👍 |
This is a fix for issue #860. While I agree that it should be fixed upstream, they have not done so in a year.