Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make doc structure consistent and up-to-date #879

Merged
merged 4 commits into from Dec 16, 2023
Merged

Conversation

Julian-O
Copy link
Contributor

Kivy-IOS

This is part of an effort to make the Kivy sibling projects' documentation
structure consistent and up-to-date.

Unrelated fixes:

  • Mild copy-edit of README
  • Mention it only works on macOS

CHECKLIST

  • CONTRIBUTING.md
    [x] If repo takes user contributions, is present
    [x] In root dir (not .github dir)
    [x] Refers to kivy/kivy Contribution Guidelines.

  • LICENSE
    [x] If repo takes user contributions, is present.
    [x] Acknowledges the range of years to 2023.
    [x] Acknowledges Kivy Team and other contributors
    [x] Mentions it is an MIT License.

  • CODE_OF_CONDUCT.md
    [x] If repo takes user contributions or hosts discussions, is present.
    [x] Refers to kivy/kivy CODE_OF_CONDUCT.md

  • CONTACT.md
    [x] Refers to kivy/kivy CONTACT.md

  • FAQ.md
    [NA] If repo is big enough for RST documentation, is present.
    ** Added anyway because it was bloating the README **

  • README:
    [x] Is a Markdown file.
    [x] Describes the project.
    [x] Describes its place in the Kivy sibling projects.
    [x] If CONTRIBUTING exists, mentions it.
    [x] If LICENSE exists, mentions it.
    [x] If CODE_OF_CONDUCT exists, mentions it.
    [x] Mentions kivy/kivy CONTACT.md
    [NA] Uses Python syntax colouring for embedded Python code.
    [x] Uses badges to display current status.

  • RST documentation, if present
    [NA] Describes the project.
    [NA] Describes its place in the Kivy sibling projects.
    [NA] Mentions LICENSE.
    [NA] Mentions CONTRIBUTING
    [NA] Mentions CODE_OF_CONDUCT
    [NA] Mentions FAQ

  • WORKFLOWS
    [x] NO_RESPONSE.yml is present if the repo has awaiting_reply tag.
    [x] NO_RESPONSE uses latest script versions.
    [x] SUPPORT.yml is present if the repo has a support tag.
    [x] SUPPORT.yml refers to kivy/kivy CONTACT.md

  • setup.py/cfg, if present and on PyPI
    [x] Supplies description to PyPI
    [x] Supplies Python versions to PyPI
    [NA] Supplies Documentation, if any, to PyPI
    [x] Supplies GitHub link to PyPI

@Julian-O Julian-O marked this pull request as draft November 28, 2023 23:34
@Julian-O Julian-O requested a review from misl6 December 12, 2023 00:00
@Julian-O Julian-O requested a review from misl6 December 13, 2023 01:43
@misl6
Copy link
Member

misl6 commented Dec 13, 2023

We have a conflict + the PR is in draft (I guess by mistake).
Can you ping me back when is ready?

@Julian-O Julian-O marked this pull request as ready for review December 13, 2023 22:21
This is part of an effort to make the Kivy sibling projects' documentation
structure consistent and up-to-date.

Unrelated fixes:
* Mild copy-edit of README
* Mention it only works on macOS

CHECKLIST

* CONTRIBUTING.md
   [x] If repo takes user contributions, is present
   [x] In root dir (not .github dir)
   [x] Refers to kivy/kivy Contribution Guidelines.

* LICENSE
   [x] If repo takes user contributions, is present.
   [x] Acknowledges the range of years to 2023.
   [x] Acknowledges Kivy Team and other contributors
   [x] Mentions it is an MIT License.

* CODE_OF_CONDUCT.md
   [x] If repo takes user contributions or hosts discussions, is present.
   [x] Refers to kivy/kivy CODE_OF_CONDUCT.md

* CONTACT.md
   [x] Refers to kivy/kivy CONTACT.md

* FAQ.md
   [NA] If repo is big enough for RST documentation, is present.
   ** Added anyway because it was bloating the README **

* README:
   [x] Is a Markdown file.
   [x] Describes the project.
   [x] Describes its place in the Kivy sibling projects.
   [x] If CONTRIBUTING exists, mentions it.
   [x] If LICENSE exists, mentions it.
   [x] If CODE_OF_CONDUCT exists, mentions it.
   [x] Mentions kivy/kivy CONTACT.md
   [NA] Uses Python syntax colouring for embedded Python code.
   [x] Uses badges to display current status.

* RST documentation, if present
   [NA] Describes the project.
   [NA] Describes its place in the Kivy sibling projects.
   [NA] Mentions LICENSE.
   [NA] Mentions CONTRIBUTING
   [NA] Mentions CODE_OF_CONDUCT
   [NA] Mentions FAQ

* WORKFLOWS
   [x] NO_RESPONSE.yml is present if the repo has awaiting_reply tag.
   [x] NO_RESPONSE uses latest script versions.
   [x] SUPPORT.yml is present if the repo has a `support` tag.
   [x] SUPPORT.yml refers to kivy/kivy CONTACT.md

* setup.py/cfg, if present and on PyPI
   [x] Supplies description to PyPI
   [x] Supplies Python versions to PyPI
   [NA] Supplies Documentation, if any, to PyPI
   [x] Supplies GitHub link to PyPI
@Julian-O
Copy link
Contributor Author

@misl6: So sorry. I believe I have those fixed now.

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Julian-O ,
I've left some review comments, can you please take a look?

.github/workflows/support.yml Outdated Show resolved Hide resolved
CONTACT.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Julian-O and others added 2 commits December 15, 2023 09:54
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
@Julian-O
Copy link
Contributor Author

@misl6 Thanks again for your diligence. Updated.

@Julian-O Julian-O requested a review from misl6 December 15, 2023 05:43
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit b54e7b5 into kivy:master Dec 16, 2023
9 checks passed
@Julian-O Julian-O deleted the hobgoblin branch December 16, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants