Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #1925 by handling URL's with parameters #1926

Merged
merged 1 commit into from Mar 3, 2014
Merged

Resolve #1925 by handling URL's with parameters #1926

merged 1 commit into from Mar 3, 2014

Conversation

nlowe
Copy link
Contributor

@nlowe nlowe commented Mar 3, 2014

Resolve issue #1925 by stripping URL parameters from a file name if the file contains them.

Before:

from kivy.core.audio import SoundLoader
s = SoundLoader.load(r"https://dl.dropboxusercontent.com/s/31iff182wy99cp1/test.wav?dl=1&token_hash=AAEjMqwEdOBUPNBVfTsDPPQW_CZPNRBgRvBNiXpRxx5btA")
s.play()
[WARNING           ] [Audio       ] Unable to find a loader for <https://dl.dropboxusercontent.com/s/31iff182wy99cp1/test.wav?dl=1&token_hash=AAEjMqwEdOBUPNBVfTsDPPQW_CZPNRBgRvBNiXpRxx5btA>

After:

from kivy.core.audio import SoundLoader
s = SoundLoader.load(r"https://dl.dropboxusercontent.com/s/31iff182wy99cp1/test.wav?dl=1&token_hash=AAEjMqwEdOBUPNBVfTsDPPQW_CZPNRBgRvBNiXpRxx5btA")
s.play()
#No error, sound plays as expected

akshayaurora added a commit that referenced this pull request Mar 3, 2014
Resolve #1925 by handling URL's with parameters
@akshayaurora akshayaurora merged commit 1149da6 into kivy:master Mar 3, 2014
@akshayaurora
Copy link
Member

@techwiz24 thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants