Modify Makefile's 'make style' to check entire tree #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The makefile targets 'style' and 'stylereport' had only checked the kivy/ directory. This allowed style errors to creep into the examples/ directory. Now 'style' will check all python files from the kivy root directory, excluding those explicitly ignored in kivy/tools/pep8checker/pep8kivy.py.
|
👍 |
dessant
added a commit
that referenced
this pull request
Feb 1, 2015
Modify Makefile's 'make style' to check entire tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makefile targets 'style' and 'stylereport' had only checked
the kivy/ directory. This allowed style errors to creep into
the examples/ directory. Now 'style' will check all python
files from the kivy root directory, excluding those
explicitly ignored in kivy/tools/pep8checker/pep8kivy.py.